Backspace will remove most recent tag if current input is empty#86
Open
Manas-Nagelia wants to merge 1 commit intoJaleelB:mainfrom
Open
Backspace will remove most recent tag if current input is empty#86Manas-Nagelia wants to merge 1 commit intoJaleelB:mainfrom
Manas-Nagelia wants to merge 1 commit intoJaleelB:mainfrom
Conversation
Added useEffect to update activeTagIndex so that if you backspace when the current input is empty it will backspace the most recent tag.
|
@Manas-Nagelia is attempting to deploy a commit to the jaleelb's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Manas-Nagelia might be better to add this as a prop since it's new functionality. |
|
Please merge this! It is much needed functionality |
|
Will it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a useEffect to update activeTagIndex so that if you backspace when the current input is empty it will delete the most recent tag. Before my commit, to use the backspace to remove an item, you would have to use the arrow key to move to the left tag and then delete it. My implementation allows the user to delete the most recent tag as long as the current topic they are typing in is empty.